This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Fix kapt issue #213
Merged
Fix kapt issue #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ects. Added special configuration-only tests that also include kotlin projects even when the tool is Kotlin only.
We were never dependant on that particular class and it seems like applying other plugins change the implementation class. Fixes #199
mr-archano
approved these changes
Nov 9, 2019
|
I'm going to merge this. I tagged @pablisco before but it is not strictly necessary for him to review. He can instead verify the fix later. I reproduced it with tests and verified the fix anyways. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Simple FileTree/FileCollection instead of ConfigurableFileTree
We were never dependant on that particular class and it seems like applying other plugins change the implementation class.
Tests
Also added tests to first reproduce it and then fix it.
For this, created new suite of tests for java-only plugins to also include Kotlin projects and test configuration.
Fixes #199