This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Bugfix: Ensure multiple runs invariant #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blundell
reviewed
Mar 20, 2017
| this.xmlReportFile = xmlReportFile | ||
| } | ||
|
|
||
| void setViolations(Violations violations) { |
There was a problem hiding this comment.
heh this reminds me of the PMD source code
blundell
reviewed
Mar 20, 2017
| } | ||
|
|
||
| File getHtmlReportFile() { | ||
| new File(xmlReportFile.absolutePath - '.xml' + '.html') |
blundell
reviewed
Mar 20, 2017
| @Override | ||
| void collectViolations(File xmlReportFile, File htmlReportFile, Violations violations) { | ||
| PmdViolationsEvaluator evaluator = new PmdViolationsEvaluator(xmlReportFile) | ||
| int errors = 0, warnings = 0 |
There was a problem hiding this comment.
just because you can, doesn't mean you should
blundell
reviewed
Mar 20, 2017
| @@ -44,6 +44,29 @@ public class CheckstyleIntegrationTest { | |||
| } | |||
|
|
|||
| @Test | |||
| public void shouldFailBuildAgainWhenCheckstyleWarningsStillOverTheThresholdAfterSecondRun() { | |||
There was a problem hiding this comment.
👍
might be nice to word it differently tho
afterSecondRunWhenStillOverTheThresholdThenTheBuildFailsAgain
or if you insist on starting with should:
shouldFailTheBuildAfterSecondRunWhenStillOverTheThreshold
blundell
approved these changes
Mar 20, 2017
ouchadam
reviewed
Mar 20, 2017
|
|
||
| import org.gradle.api.tasks.JavaExec | ||
|
|
||
| class GenerateFindBugsHtmlReport extends JavaExec { |
|
nice set of tests for each plugin, LGTM ! 👍 |
ouchadam
approved these changes
Mar 20, 2017
This was referenced Mar 21, 2017
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of the PR
As @ouchadam mentioned in issue #11:
This shouldn't happen because code is identical, therefore should yield the same results. As already mentioned in #11, after a quick investigation:
Considerations and implementation
Each analysis task (
Checkstyle,Findbugs,Pmd) is now depending on a specific implementation ofCollectionViolationsTaskthat will perform the same action before provided asdoLast. This will allow to evaluate the reports and collect the violations even when the analysis are skipped because their input haven't changed.Test(s) added
For each tool supported by the plugin an integration test has been added to ensure that 2 consecutive runs without any change in the code yield the same result.