This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Don't override default effort and report level #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-archano
approved these changes
Nov 10, 2016
| maxErrors = 0 | ||
| maxWarnings = 1 | ||
| }''') | ||
| .withFindbugs('findbugs { effort = \'max\' \n reportLevel = \'low\'}') |
There was a problem hiding this comment.
you could use " instead of escaping '
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of the PR
The effort and report level of FindBugs were enforced by us, overriding the defaults, but this is something that a user might not want. Leave the defaults in place, and let the user choose if he wants other values.
Considerations/Implementation Details
Really straight forward, just remove setting the values in the task configurator.
Since by default FindBugs is not that restrictive anymore,
LowPriorityViolator.javawas updated to contain a violation with priority 3 that will get picked up with the defaults.Testing
Updated (fix) test that said that it should fail build when threshold is passed
Added a test to showcase how one can change the effort and report level