This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Clean up variant aware code #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasomaniac
commented
Feb 9, 2018
| source = sourceSet.java.srcDirs | ||
| classpath = files("$buildDir/intermediates/classes/") | ||
| } | ||
| variant.sourceSets.each { sourceSet -> |
There was a problem hiding this comment.
Just 1 level indentation deleted, no change.
tasomaniac
force-pushed
the
clean-up
branch
5 times, most recently
from
5149d63
to
e8b1f43
Compare
|
retest this please |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DomainObjectSet.allloop is live and thanks to that usuallyafterEvaluateis not necessary because the closure will be called later (just after) the variants have been added.getAllVariantswas merging android variants with test and unitTest variants. This was breaking the liveliness of the set. That's why we neededafterEvaluate.Since the variant aware code is extracted away, this PR cleans this up by calling
allon variants one by one instead of merging them.And thanks to that, the for looping over variants happen in the base class. This means that the implementations for Checkstyle, Findbugs and PMD are cleaner because they configure 1 variant at a time.