This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Fix properties in release script #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-archano
reviewed
Feb 13, 2018
| @@ -70,10 +70,10 @@ publishGhPages.dependsOn prepareGhCredentials | |||
|
|
|||
| task prepareGradlePluginsRepoRelease { | |||
| doLast { | |||
| String key = buildProperties.env['GRADLE_PLUGINS_REPO_KEY'].or(buildProperties.secrets['gradle.publish.key']).string | |||
| String secret = buildProperties.env['GRADLE_PLUGINS_REPO_SECRET'].or(buildProperties.secrets['gradle.publish.secret']).string | |||
| project.setProperty('gradle.publish.key', key) | |||
There was a problem hiding this comment.
I assumed this was working as @tobiasheine did the last release to Gradle Plugins Portal; does it mean that it wasn't the case?
There was a problem hiding this comment.
In that release properties were read from a file. This change was not tested.
There was a problem hiding this comment.
@mr-archano the last release was not yet automated. This is the first one.
tobiasheine
approved these changes
Feb 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release script failed with
MissingPropertyExceptionwhile trying to set the property.It seems that
setPropertyis meant to be used when the property is already available. If not, it throws an exception. The following map interface throughpropertiesmap seems to be the way to do it.While doing so, I also used or operator instead of the or method. Since it has less parenthesis, I think it is easier to see what's going on. I can revert that if wanted.