This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Verify detekt config #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-archano
suggested changes
Feb 15, 2018
| @@ -25,6 +28,26 @@ class DetektIntegrationTest { | |||
| this.projectRule = projectRule | |||
| } | |||
|
|
|||
| @Test | |||
| void givenOutputNotDefinedShouldFailBuildOnConfiguration() { | |||
There was a problem hiding this comment.
the name of this test could be shouldFailBuildOnConfigurationWhenOutputNotDefined
There was a problem hiding this comment.
haha 😃The test name was like that in the beginning actually.
mr-archano
approved these changes
Feb 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70
Problem
We don't verify the tools configurations but maybe we should in some cases. In this particular case,
outputis optional in detekt and in such case, it just prints to console and skips generating file reports.When this happens, our plugin fails with an exception while running with not so clear error message.
Solution
Check if the
outputis defined.Tests