This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Multiple config support for tools #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasomaniac
commented
Feb 16, 2018
| @@ -80,9 +80,9 @@ class CheckstyleConfigurator extends CodeQualityConfigurator<Checkstyle, Checkst | |||
| } | |||
|
|
|||
| private CollectCheckstyleViolationsTask createCollectViolationsTask(Checkstyle checkstyle, Violations violations) { | |||
| project.tasks.create("collect${checkstyle.name.capitalize()}Violations", CollectCheckstyleViolationsTask) { collectViolations -> | |||
There was a problem hiding this comment.
😞 Old version looks much better but unfortunately the same thing is not available for maybeCreate
And with does not make it better since with returns the last statement, I still need to return task manually.
|
I don't understand what went wrong with this build - the error is about the missing resolution of the Detekt artifact, but I can't see any change in this PR affecting that. @hal90002 could you retest this please? |
mr-archano
approved these changes
Feb 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like Android Lint, main tools (pmd, findbugs, checkstyle) also had the same problem where if the user configures them multiple times, the configuration fails.
Tests were written first and then when
task already existsproblems happen, task creations are converted tomaybeCreate