Remove Log class

[blundell]

Remove the Merlin Log class & add a dependency on NoTils

https://github.com/novoda/merlin/blob/master/core/src/main/java/com/novoda/merlin/Log.java

[ouchadam]

do we want to add another dependency to this library? Would we be better off renaming Log to MerlinLog?

[blundell]

Gradle is clever enough that adding an internal dependency to NoTils is fine.

[ouchadam]

I don't want to pull in all those Notils methods though 😖

[blundell]

Why not, what is the downside?

[xrigau]

forcing libraries in libraries is not cool, it just adds more than what it's supposed. i.e. If I want to use Merlin it is because it does 1 thing and it works well, but I'm forced to use NoTils just because Merlin wants to log using the SimpleLog. What if I'm not gonna use anything in NoTils? I'd just have it there for a simple log, doesn't make much sense

[blundell]

The idea is nobody knows you are using NoTils. I don't think your argument is valid, your saying no library can never use any help (another library) from anywhere.

We're already using keviswiki's HTTP client, what if we wanted to use Guava, or the Support Librarys or ViewPagerIndicator or Gson. Are you saying you'd want to roll your own json parser in every library? :-)

[ouchadam]

Except you'll end up having to exclude notils if you start to run out of methods!
In this case we would only use the SimpleLog. I'm also planning to remove the HttpRequest library

[blundell]

I can see what you're thinking its kind of a pre-optimisation tho. I
wouldn't do that extra work myself
On 12 Jul 2014 17:55, "Adam Brown" notifications@github.com wrote:

Except you'll end up having to exclude notils if you start to run out of
methods!
In this case we would only use the SimpleLog. I'm also planning to remove
the HttpRequest library

—
Reply to this email directly or view it on GitHub
#19 (comment).

[blundell]

@xrigau @ouchadam I am happy to go with your decision, if you choose now - Are we going to include NoTils for logging (& possibly further useage i.e. when we discussed this simple connection test) or will we rename Log to MerinLog ?

[ouchadam]

another solution would be to simply use Android.Log without the wrapper class

[ouchadam]

renaming the MerlinLog is the simplest fix

[xrigau]

👍 for renaming