Skip to content
This repository has been archived by the owner on Feb 11, 2022. It is now read-only.

Test NoPlayerAdsLoader #272

Closed
Mecharyry opened this issue Jul 24, 2019 · 0 comments
Closed

Test NoPlayerAdsLoader #272

Mecharyry opened this issue Jul 24, 2019 · 0 comments
Labels
enhancement housekeeping

Comments

@Mecharyry
Copy link
Contributor

Problem

NoPlayerAdsLoader has a lot of state and logic. We rely quite heavily on this and it is essentially untested.

Potential Solution

Move all logic to another collaborator that is testable.

Impact

Fewer bugs and documentation on how the AdsLoader works. We'll be able to more easily deal with production issues if we can reproduce them with tests.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement housekeeping
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mecharyry @juankysoriano