Skip to content
This repository has been archived by the owner on Feb 11, 2022. It is now read-only.

onVideoStopped is double called #72

Closed
Mecharyry opened this issue Jul 18, 2017 · 1 comment
Closed

onVideoStopped is double called #72

Mecharyry opened this issue Jul 18, 2017 · 1 comment
Labels
addressed bug

Comments

@Mecharyry
Copy link
Contributor

Problem

As per this, on stop and on release both call onVideoStopped.

Potential Solution

Only emit a state if it is different from the previous state. Similar to how we handle it for the play here.

Impact

Clients should not need to deal with multiple calls to the same state, it could potentially lead to inconsistencies and crashes, especially if we delay patching this.
@Mecharyry Mecharyry added the bug label Jul 18, 2017
@Mecharyry Mecharyry mentioned this issue Aug 7, 2017
Merged
@Mecharyry
Copy link
Contributor Author

This has been addressed and released as part of v2.0.6

@Mecharyry Mecharyry moved this from In Progress to Ready for Release in Issue Tracker Aug 14, 2017
@Mecharyry Mecharyry removed this from Ready for Release in Issue Tracker Aug 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
addressed bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Mecharyry