This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
NO-72/Stop double calling state changes #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 4, 2017 11:17
|
test this please |
ouchadam
reviewed
Aug 7, 2017
| @@ -23,22 +31,40 @@ void clear() { | |||
|
|
|||
| @Override | |||
| public void onVideoPlaying() { | |||
| if (currentState == State.PLAYING) { | |||
| return; | |||
There was a problem hiding this comment.
do you think it's worth logging these scenarios?
There was a problem hiding this comment.
Yes, can never have too many logs 😄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As per #72, state changes are being double called. An example of this can be seen here. Clients do not need to call
stopas long as they callrelease,releasecallsstopinternallywhich notifies of theonVideoStopped` event.Solution
Swallow double calls of state through the
StateChangedListeners.Test(s) added
Yes, tested that double calling swallows the most recent event.
Screenshots
No UI changes.
Paired with
Nobody, but I did have a chat with @ouchadam about this 😄