You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
We have a number of calls that rely on calling methods on the PlayerView. When calling on the Player, another class that can be null, we assert and throw should this be null.
Potential Solution
Check if PlayerView is null and throw informing clients that they must attach a PlayerView in order to interact with it.
Impact
Consistency in the codebase to how we handle @Nullable. More informative error messaging for a user should they forget to attach a PlayerView rather than a NullPointer.
The text was updated successfully, but these errors were encountered:
We're only asserting when loadVideo is called in the future we would like the library to be able to handle playback without a playerView for example continuing video playback as audio only.
We should drop this issue then. I'll open a new one for what we plan in the future. Thanks @ouchadam. Sorry @Kartik2016 for the misinformation on this issue.
Problem
We have a number of calls that rely on calling methods on the
PlayerView
. When calling on thePlayer
, another class that can be null, we assert and throw should this be null.Potential Solution
Check if
PlayerView
is null and throw informing clients that they must attach aPlayerView
in order to interact with it.Impact
Consistency in the codebase to how we handle
@Nullable
. More informative error messaging for a user should they forget to attach aPlayerView
rather than aNullPointer
.The text was updated successfully, but these errors were encountered: