Skip to content
This repository has been archived by the owner on Feb 11, 2022. It is now read-only.

Assert PlayerView is attached #78

Closed
Mecharyry opened this issue Jul 27, 2017 · 4 comments
Closed

Assert PlayerView is attached #78

Mecharyry opened this issue Jul 27, 2017 · 4 comments

Comments

@Mecharyry
Copy link
Contributor

Problem

We have a number of calls that rely on calling methods on the PlayerView. When calling on the Player, another class that can be null, we assert and throw should this be null.

Potential Solution

Check if PlayerView is null and throw informing clients that they must attach a PlayerView in order to interact with it.

Impact

Consistency in the codebase to how we handle @Nullable. More informative error messaging for a user should they forget to attach a PlayerView rather than a NullPointer.

@Kartikdot
Copy link

Is the issue still open ? If yes please assign it to me id like to work on it! Thanks.

@Mecharyry
Copy link
Contributor Author

I have a feeling that this was achieved mostly in the newest update of the library, @ouchadam can you confirm?

@ouchadam
Copy link
Contributor

We're only asserting when loadVideo is called in the future we would like the library to be able to handle playback without a playerView for example continuing video playback as audio only.

@Mecharyry
Copy link
Contributor Author

We should drop this issue then. I'll open a new one for what we plan in the future. Thanks @ouchadam. Sorry @Kartik2016 for the misinformation on this issue.

@Mecharyry Mecharyry removed this from To Do in Issue Tracker May 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants