This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Ensure DASH media sources report bitrate changes #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joetimmins
changed the title
added 2 commits
July 5, 2018 17:50
Mecharyry
approved these changes
Jul 5, 2018
pablisco
approved these changes
Jul 5, 2018
ouchadam
reviewed
Jul 6, 2018
| DefaultDashChunkSource.Factory chunkSourceFactory = new DefaultDashChunkSource.Factory(defaultDataSourceFactory); | ||
| DashMediaSource.Factory factory = new DashMediaSource.Factory(chunkSourceFactory, defaultDataSourceFactory); | ||
| return factory.createMediaSource(uri); |
There was a problem hiding this comment.
I wonder if this is a smell that we're applying the eventListeners at the wrong level?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Bitrate listeners aren't hearing any bitrate change events when playing DASH content.
Solution
When we create a DASH media source, use the given MediaSourceEventListener instance to ensure all of the noplayer listeners make it into exoplayer.
Test(s) added
There's no tests around the MediaSourceFactory class and it would be very difficult to add them.
In order to test this works, add a new BitrateChangedListener in the DemoPresenter with some logging in it. Run the demo, check Logcat to see it appear. I made this change but reverted it as I couldn't see any similar code doing anything like it.
Paired with
Given good direction by @Mecharyry