This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Fix video changed listener #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zegnus
reviewed
Jul 12, 2018
| @Override | ||
| public void onDroppedFrames(int count, long elapsedMs) { | ||
| for (VideoRendererEventListener listener : listeners) { | ||
| listener.onDroppedFrames(count, elapsedMs); |
There was a problem hiding this comment.
we do not have this callback anymore?
There was a problem hiding this comment.
No we don't. The only place it is exposed by exoplayer is on the VideoRendererEventListener, which can't be attached to exoplayer directly any more.
There was a problem hiding this comment.
@Mecharyry do we still have this info in the analytics listener? or now we cannot know if we have dropped frames at all?
There was a problem hiding this comment.
Ah yes, onDroppedVideoFrames on exoplayer's AnalyticsListener is the one we want.
| } | ||
|
|
||
| @Override | ||
| public void onVideoDecoderInitialized(String decoderName, long initializedTimestampMs, long initializationDurationMs) { |
There was a problem hiding this comment.
we do not have this callback anymore? and others...
There was a problem hiding this comment.
These are exposed through the analytics listener now.
Mecharyry
approved these changes
Jul 12, 2018
zegnus
approved these changes
Jul 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The method on
exoplayerto attach aVideoRendererEventListenerhas been deprecated. That means we weren't attaching ourVideoSizeChangedListenerproperly.Solution
Change the forwarder to implement exoplayer's new
VideoListenerand attach it in the facade.Test(s) added
I'm not sure there's any worthwhile tests to add here. What we really need is the capability to say, when we've created a player, and that player sends an
onVideoSizeChangedevent, our event listeners all hear it. However, it's not possible to write a test like that right now. It would also be quite an undertaking as we'd need a fake exoplayer which is kept up to date with the version we're targeting.Paired with
No one