Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another change to chrome history module #81

Merged
merged 5 commits into from Feb 5, 2020

Conversation

balaramadurai
Copy link
Contributor

Hi Karl (@novoid) ,
Thank you for doing a sanity check on the module. I found out that I have been stuck to python 2.7, when the rest of the stuff is python3.6. (My complete ignorance of python 😄 )

Now, I have changed everything to python3 and also changed the sql query to accurately reflect the sqlite structure of Google Chrome.

I tested this on 2 browsers - Google Chrome and Vivaldi (a browser which depends on Chromium). It seems to work.

Please do let me know if this works ok for you.

I use the command

bala@LinuxMint ~/Downloads/Memacs $ python3 bin/memacs_chrome.py --file ~/.config/google-chrome/Default/History | more
## -*- coding: utf-8 mode: org -*-
 ## this file is generated by bin/memacs_chrome.py. Any modification will be overwritten upon next invocation!
 ## To add this file to your org-agenda files open the stub file  (file.org) not this file(file.org_archive) with emacs and do following: M-x org-agenda-file-to-front
 * Memacs for chrome url history           :Memacs:chrome:
 ** <1970-01-01 Thu 00:00> 
    :PROPERTIES:
   :URL:         https://www.youtube.com/playlist?list=WL
   :VISIT_COUNT: 0
   :ID:          c24d204aed167202a675e901bb4b8e876fb40ed9
   :END:

Thanks and have a great day!
Bala

- changed shebang of chrome.py and memacs_chrome.py
- type=file had to be changed to type=open (copied from firefox.py)
@novoid novoid merged commit e2dc58a into novoid:master Feb 5, 2020
@novoid
Copy link
Owner

novoid commented Feb 5, 2020

I'm so sorry. I've lost touch to this merge request for way too long. No idea why this happened. Maybe I'm not following the new GitHub notification system way of life ...

@balaramadurai
Copy link
Contributor Author

balaramadurai commented Feb 10, 2020 via email

@novoid
Copy link
Owner

novoid commented Feb 10, 2020

Sorry @balaramadurai,
I personally don't use Chrome and therefore, I can't really test it properly. Should I ask for testers via Twitter/Mastodon?

@balaramadurai
Copy link
Contributor Author

balaramadurai commented Feb 12, 2020 via email

@novoid
Copy link
Owner

novoid commented Feb 12, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants