Add a workaround for #176 #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `@(NativeReference)` is used for other things in .NET, so make sure to remove the incorrect file. novotnyllc#176
|
Happy to merge, but any chance you can add a test case/repro to the test projects? |
mattleibow
commented
Aug 13, 2019
| @@ -34,4 +34,12 @@ | |||
| <Error Text="The Binding Project for $(_SdkTargetPlatformName) is only supported with only C#, not with $(_SdkLanguageSourceName). Please change the project to C# to use the Bindings Project.'"/> | |||
| </Target> | |||
|
|
|||
| <!-- A workaround for https://github.com/microsoft/msbuild/issues/4584 and resolves https://github.com/onovotny/MSBuildSdkExtras/issues/176 --> | |||
| <Target Name="_RemoveNativeReferencesManifest" Condition="'$(IsApplePlatform)' == 'true'" AfterTargets="BuiltProjectOutputGroup"> | |||
There was a problem hiding this comment.
I updated this to exclude the binding projects test because @(NativeReference) is also valid in non-binding projects.
|
Is this ready to go now? |
mattleibow
commented
Aug 13, 2019
| @@ -32,6 +32,10 @@ | |||
| <Reference Include="System.Xml" /> | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup Condition="'$(TargetFramework)' == 'xamarin.ios10'"> | |||
| <NativeReference Include="Resource1.resx" /> | |||
There was a problem hiding this comment.
The actual contents of the file is unimportant because it is only used at app link-time. Also, in order for this test to pass/fail, you need to pack. The issue does not arise in build because iOS never references the "generated" file. But, the pack target does when it tries to pack it.
|
I think we are good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@(NativeReference)is used for other things in .NET, so make sure to remove the incorrect file. #176Sample bug here: https://github.com/mattleibow/XamarinNativeReferencesBug