Skip to content

Commit

Permalink
Fix ResolverListener so that ServiceLost is called only after N succe…
Browse files Browse the repository at this point in the history
…ssive failed pings.
  • Loading branch information
spudwebb committed Aug 14, 2019
1 parent e2246a1 commit 058888b
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion Zeroconf/ZeroConfResolver.Listener.cs
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,9 @@ void OnResolved(IReadOnlyList<IZeroconfHost> hosts)
{
ServiceFound?.Invoke(this, host);
newHosts.Add(keyValue);
if (toRemove.ContainsKey(keyValue)) toRemove.Remove(keyValue);
}
if (toRemove.ContainsKey(keyValue))
toRemove.Remove(keyValue);
}
}

Expand Down

4 comments on commit 058888b

@captain-git
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@onovotny - We are facing this issue with zeroconf v2.9.0 in our application, which targets .Net framework v4.5. I saw that it has been fixed in v3.1.29 and higher version which targets .Net v4.6.1, so can you please let me know how can I get the library with this fix which targets .Net 4.5.

@clairernovotny
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

I don't have any plans to release a version that targets an earlier version. NET 4.5.0 hasn't been supported for some time. You're free to build your own version if you need.

@captain-git
Copy link

@captain-git captain-git commented on 058888b Jan 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@onovotny -
You mean to say that I need to build the custom version of v2.9.0 with the above fix and use it in my application and it will not violate any license agreement, right? One more thing, to get strong-named DLL, Can I use my own key.snk or yours?.

@captain-git
Copy link

@captain-git captain-git commented on 058888b Jan 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@onovotny -
Also, should I raise a pull request to fix this issue in v2.9.0?

Please sign in to comment.