Xamarin.iOS: Add workaround for new restrictions in iOS 14.5+ #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clairernovotny
requested changes
Aug 11, 2021
Zeroconf/BonjourBrowser.cs
Outdated
| { | ||
| NSNetService netService = null; | ||
|
|
||
| if (sender is NSNetService) |
There was a problem hiding this comment.
this could be simplified to be sender is NSNetService netService
…ot have to provide values; exposes iOS mDNS domain name search; NSNetService.Resolve timeout is same as ScanTime (was hardcoded), provide was for library caller to force-disable the workaround, even on iOS 14.5+; added documentation
|
OK, added some documentation. In doing so, realized what a PITA it would be to duplicate and maintain the Info.plist entries in code... so added code to read the Info.plist internally. This led to supporting non .local domain names, which led to querying the network for active domain names. All this is library-consumer controlled, so complexity is only for those who need it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses iOS NSNetServiceBrowser/NSNetService instead of BSD sockets. Some items visible using raw sockets are not available in NSNetServiceBrowser and friends. Also, by definition, this code can only browse services it requests permission to see via Info.plist entries.