Refactor Registration Page to use EL #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reecebenson
reviewed
Nov 16, 2019
Comment on lines
+5
to
+15
| <c:choose> | ||
| <c:when test="${registerStatus == 'success'}"> | ||
| <t:registersuccess /> | ||
| </c:when> | ||
| <c:when test="${registerStatus == 'fail'}"> | ||
| <t:registerfail /> | ||
| </c:when> | ||
| <c:otherwise> | ||
| <t:registerform /> | ||
| </c:otherwise> | ||
| </c:choose> |
There was a problem hiding this comment.
Ah this is dope! Nice work :)
reecebenson
approved these changes
Nov 16, 2019
Comment on lines
+44
to
+45
|
|
||
|
|
There was a problem hiding this comment.
Unnecessary line breaks, but won't stop a merge.
| </div> | ||
| </div> | ||
| <div class="col s12 center-align"> | ||
| Already have an account? <a href="login">Login here</a>. |
There was a problem hiding this comment.
Could use ${pageContext.request.contextPath}/login for path consistency :)
| <div class="col s12 center-align"> | ||
| <div class="red-text"> | ||
| Please ensure you make a note of this password before proceeding to | ||
| <a href="login">login</a> |
There was a problem hiding this comment.
Could use ${pageContext.request.contextPath}/login for path consistency :)
| @@ -1,97 +1,10 @@ | |||
| <%@ page contentType="text/html;charset=UTF-8" language="java" %> | |||
| <%@taglib prefix="t" tagdir="/WEB-INF/tags"%> | |||
| <%@ taglib uri = "http://java.sun.com/jsp/jstl/core" prefix = "c" %> | |||
There was a problem hiding this comment.
We could remove the spaces here around the attribute/values, etc.
reecebenson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.