New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pushpad provider documentation #344
Conversation
|
||
``` | ||
|
||
Device/notification identifiers can be set by using [setCredentials](https://docs.novu.co/channels/email/resend/#set-device-token) or by using the `deviceIdentifiers` field in overrides. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a valid URL. Please can you change it to https://docs.novu.co/channels-and-providers/push/push-webhook#set-device-token
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@unicodeveloper I got that link from the docs of other push providers, but I agree that it seems broken at the moment. I don't like the idea to link to another provider (push-webhook), that is confusing. I see that the example for setCredentials
is just in the paragraph above, so I removed the link and improved the sentence.
|
||
[Pushpad](https://pushpad.xyz) is a web push service that supports sending notifications to all major browsers (Chrome, Firefox, Edge, Safari, etc.) via FCM, Mozilla autopush, Windows Push Notification Services and Apple Push Notification service, with just one simple API. | ||
|
||
To configure the Pushpad integration, you will need an active account and you need to have a `Pushpad Auth Token` (from the account settings) and the `Pushpad Project ID` (from the project settings). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please can you link to the account settings and the project settings URLs here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@unicodeveloper I have added the requested link for account settings. The link for project settings cannot be added because I would need the project ID to write the URL (but you just need to click "Settings" in the Pushpad project, so it is clear for the user).
Pushpad provider has been added to Novu here:
novuhq/novu#4235
This pull requests adds the documentation for this provider.