Skip to content

Commit

Permalink
Nv 2906 remove the is topic notification enabled feature flag (#5493)
Browse files Browse the repository at this point in the history
Remove unused injections
Move single use helper to class using it
Remove unused imports
Tidy up imports
Remove map-trigger-recipients use case
Remove associated e2e tests
Remove setting of feature flag in e2e tests
Remove feature flag from env validator
Remove feature flag from env configurations
Remove feature flag from list of feature flags
Remove feature flag read and false handling from trigger-multicast use case
Add (ugly) solution to verify matching of enum name and value
Ignore example env config for spell check
Ensure feature flag enum keys match values
Name variable underscore to imply non-use
Refactor tests for flag test specs
Remove additional occurrences of feature flag that isn't required
  • Loading branch information
denis-kralj-novu committed May 7, 2024
1 parent 134fcae commit 531ba2d
Show file tree
Hide file tree
Showing 26 changed files with 44 additions and 967 deletions.
3 changes: 2 additions & 1 deletion .cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -739,6 +739,7 @@
".env.development",
".env.local",
".env.production",
".env.test"
".env.test",
".example.env",
]
}
1 change: 0 additions & 1 deletion apps/api/src/.env.development
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ LOGGING_LEVEL=info
VERCEL_REDIRECT_URI=https://dev.web.novu.co/auth/login
VERCEL_BASE_URL=https://api.vercel.com

IS_TOPIC_NOTIFICATION_ENABLED=true
FF_IS_DISTRIBUTED_LOCK_LOGGING_ENABLED=false
IS_TRANSLATION_MANAGER_ENABLED=false

Expand Down
1 change: 0 additions & 1 deletion apps/api/src/.env.production
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ LOGGING_LEVEL=info
VERCEL_REDIRECT_URI=https://web.novu.co/auth/login
VERCEL_BASE_URL=https://api.vercel.com

IS_TOPIC_NOTIFICATION_ENABLED=true
FF_IS_DISTRIBUTED_LOCK_LOGGING_ENABLED=false
IS_TRANSLATION_MANAGER_ENABLED=false

Expand Down
2 changes: 0 additions & 2 deletions apps/api/src/.env.test
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,6 @@ VERCEL_CLIENT_SECRET=
VERCEL_REDIRECT_URI=http://127.0.0.1:4200/auth/login
VERCEL_BASE_URL=https://api.vercel.com

IS_TOPIC_NOTIFICATION_ENABLED=true

STORE_NOTIFICATION_CONTENT=true

MAX_NOVU_INTEGRATION_MAIL_REQUESTS=300
Expand Down
1 change: 0 additions & 1 deletion apps/api/src/.example.env
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ VERCEL_CLIENT_SECRET=
VERCEL_REDIRECT_URI=http://127.0.0.1:4200/auth/login
VERCEL_BASE_URL=https://api.vercel.com

IS_TOPIC_NOTIFICATION_ENABLED=true
IS_TRANSLATION_MANAGER_ENABLED=false

STORE_NOTIFICATION_CONTENT=true
Expand Down

0 comments on commit 531ba2d

Please sign in to comment.