chore: add suggested changes

novuhq · Mar 4, 2024 · 55cc565 · 55cc565
1 parent 51956c7
commit 55cc565
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 3 deletions.
diff --git a/apps/api/src/config/env-validator.ts b/apps/api/src/config/env-validator.ts
@@ -1,4 +1,9 @@
 import { bool, cleanEnv, json, makeValidator, port, str, num, url, ValidatorSpec } from 'envalid';
+import {
+  DEFAULT_MESSAGE_GENERIC_RETENTION_DAYS,
+  DEFAULT_MESSAGE_IN_APP_RETENTION_DAYS,
+  DEFAULT_NOTIFICATION_RETENTION_DAYS,
+} from '@novu/shared';
 
 const str32 = makeValidator((variable) => {
   if (!(typeof variable === 'string') || variable.length != 32) {
@@ -88,6 +93,15 @@ const validators: { [K in keyof any]: ValidatorSpec<any[K]> } = {
     default: 'false',
     choices: ['false', 'true'],
   }),
+  NOTIFICATION_RETENTION_DAYS: num({
+    default: DEFAULT_NOTIFICATION_RETENTION_DAYS,
+  }),
+  MESSAGE_GENERIC_RETENTION_DAYS: num({
+    default: DEFAULT_MESSAGE_GENERIC_RETENTION_DAYS,
+  }),
+  MESSAGE_IN_APP_RETENTION_DAYS: num({
+    default: DEFAULT_MESSAGE_IN_APP_RETENTION_DAYS,
+  }),
 };
 
 if (process.env.STORAGE_SERVICE === 'AZURE') {

diff --git a/apps/api/src/types/env.d.ts b/apps/api/src/types/env.d.ts
@@ -25,6 +25,9 @@ declare global {
       SENTRY_DSN: string;
       STRIPE_API_KEY: string;
       STRIPE_CONNECT_SECRET: string;
+      NOTIFICATION_RETENTION_DAYS?: number;
+      MESSAGE_GENERIC_RETENTION_DAYS?: number;
+      MESSAGE_IN_APP_RETENTION_DAYS?: number;
     }
   }
 }
diff --git a/apps/worker/src/config/env-validator.ts b/apps/worker/src/config/env-validator.ts
@@ -1,4 +1,9 @@
 import { cleanEnv, json, port, str, num, ValidatorSpec, makeValidator } from 'envalid';
+import {
+  DEFAULT_MESSAGE_GENERIC_RETENTION_DAYS,
+  DEFAULT_MESSAGE_IN_APP_RETENTION_DAYS,
+  DEFAULT_NOTIFICATION_RETENTION_DAYS,
+} from '@novu/shared';
 
 const str32 = makeValidator((variable) => {
   if (!(typeof variable === 'string') || variable.length != 32) {
@@ -54,13 +59,13 @@ const validators: { [K in keyof any]: ValidatorSpec<any[K]> } = {
     default: undefined,
   }),
   NOTIFICATION_RETENTION_DAYS: num({
-    default: 30,
+    default: DEFAULT_NOTIFICATION_RETENTION_DAYS,
   }),
   MESSAGE_GENERIC_RETENTION_DAYS: num({
-    default: 30,
+    default: DEFAULT_MESSAGE_GENERIC_RETENTION_DAYS,
   }),
   MESSAGE_IN_APP_RETENTION_DAYS: num({
-    default: 365,
+    default: DEFAULT_MESSAGE_IN_APP_RETENTION_DAYS,
   }),
 };