Merge pull request #2226 from ArturHamannRonconi/fix/ses-provider-sen…

…der-name fix: use sender name with from email in ses provider
novuhq · Dec 12, 2022 · 73d9612 · 73d9612
2 parents 859b570 + 25ab4a1
commit 73d9612
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 5 deletions.
diff --git a/apps/api/src/app/events/services/mail-service/handlers/ses.handler.ts b/apps/api/src/app/events/services/mail-service/handlers/ses.handler.ts
@@ -13,6 +13,7 @@ export class SESHandler extends BaseHandler {
       region: credentials.region,
       accessKeyId: credentials.apiKey,
       secretAccessKey: credentials.secretKey,
+      senderName: credentials.senderName ?? 'no-reply',
       from,
     };
 

diff --git a/packages/application-generic/src/factories/mail/handlers/ses.handler.ts b/packages/application-generic/src/factories/mail/handlers/ses.handler.ts
@@ -13,6 +13,7 @@ export class SESHandler extends BaseHandler {
       region: credentials.region,
       accessKeyId: credentials.apiKey,
       secretAccessKey: credentials.secretKey,
+      senderName: credentials.senderName ?? 'no-reply',
       from,
     };
 

diff --git a/providers/ses/src/lib/ses.config.ts b/providers/ses/src/lib/ses.config.ts
@@ -1,7 +1,8 @@
 // eslint-disable-next-line @typescript-eslint/naming-convention
 export interface SESConfig {
+  from: string;
   region: string;
+  senderName: string;
   accessKeyId: string;
   secretAccessKey: string;
-  from: string;
 }
diff --git a/providers/ses/src/lib/ses.provider.spec.ts b/providers/ses/src/lib/ses.provider.spec.ts
@@ -11,10 +11,11 @@ test('should trigger ses library correctly', async () => {
     });
 
   const mockConfig = {
-    from: 'test@test.com',
+    region: 'test-1',
+    senderName: 'Test',
     accessKeyId: 'TEST',
+    from: 'test@test.com',
     secretAccessKey: 'TEST',
-    region: 'test-1',
   };
   const provider = new SESEmailProvider(mockConfig);
 

diff --git a/providers/ses/src/lib/ses.provider.ts b/providers/ses/src/lib/ses.provider.ts
@@ -31,12 +31,15 @@ export class SESEmailProvider implements IEmailProvider {
     });
 
     return await transporter.sendMail({
+      to,
       html,
       text,
-      to,
-      from,
       subject,
       attachments,
+      from: {
+        address: from,
+        name: this.config.senderName,
+      },
     });
   }