We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for sending attachments for our Mailjet provider.
To have the ability to use send attachments.
Based on Notifire IAttachmentOptions interface found here. And Mailjet method found here
Based on Notifire IAttachmentOptions interface on the trigger.
The text was updated successfully, but these errors were encountered:
Hey, I would like to work on this issue.
Sorry, something went wrong.
@devblin Sure! Assigned you. Create your branch from the v0.3.0 branch to get the attachment interface
Just in case that helps,
Hey, so for inline-attachments there is no inline-attachment attribute in IEmailOptions interface, so we need to update this https://github.com/notifirehq/notifire/blob/725e5d279ce5ab6f1a85aaefe190db528fda3054/packages/core/src/lib/provider/provider.interface.ts#L11 And, also in given attachment interface, we need to add id attribute as for mailjet-inline-attachments there is optional parameter ContentID https://github.com/notifirehq/notifire/blob/725e5d279ce5ab6f1a85aaefe190db528fda3054/packages/core/src/lib/template/template.interface.ts#L43
inline-attachment
IEmailOptions
id
ContentID
@devblin for now let's leave the inline attachments out of the scope of this issue and just focus on regular attachments.
devblin
No branches or pull requests
What?
Add support for sending attachments for our Mailjet provider.
Why?
To have the ability to use send attachments.
How?
Based on Notifire IAttachmentOptions interface found here.
And Mailjet method found here
Usage
Based on Notifire IAttachmentOptions interface on the trigger.
The text was updated successfully, but these errors were encountered: