Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mailjet attachments support #101

Closed
Tracked by #21
scopsy opened this issue Nov 7, 2021 · 5 comments
Closed
Tracked by #21

Mailjet attachments support #101

scopsy opened this issue Nov 7, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers @notifire/mailjet
Milestone

Comments

@scopsy
Copy link
Contributor

scopsy commented Nov 7, 2021

What?

Add support for sending attachments for our Mailjet provider.

Why?

To have the ability to use send attachments.

How?

Based on Notifire IAttachmentOptions interface found here.
And Mailjet method found here

Usage

Based on Notifire IAttachmentOptions interface on the trigger.

@scopsy scopsy mentioned this issue Nov 7, 2021
11 tasks
@scopsy scopsy added good first issue Good for newcomers help wanted Extra attention is needed labels Nov 7, 2021
@scopsy scopsy added this to the v0.3.0 milestone Nov 7, 2021
@devblin
Copy link
Contributor

devblin commented Nov 13, 2021

Hey, I would like to work on this issue.

@scopsy
Copy link
Contributor Author

scopsy commented Nov 13, 2021

@devblin Sure! Assigned you. Create your branch from the v0.3.0 branch to get the attachment interface

@ComBarnea ComBarnea added @notifire/mailjet enhancement New feature or request and removed help wanted Extra attention is needed labels Nov 13, 2021
@ComBarnea
Copy link
Collaborator

Just in case that helps,

How to send single/multiple and inline with Mailjet

Screen Shot 2021-11-13 at 11 27 52

@devblin
Copy link
Contributor

devblin commented Nov 16, 2021

Hey, so for inline-attachments there is no inline-attachment attribute in IEmailOptions interface, so we need to update this https://github.com/notifirehq/notifire/blob/725e5d279ce5ab6f1a85aaefe190db528fda3054/packages/core/src/lib/provider/provider.interface.ts#L11
And, also in given attachment interface, we need to add id attribute as for mailjet-inline-attachments there is optional parameter ContentID
https://github.com/notifirehq/notifire/blob/725e5d279ce5ab6f1a85aaefe190db528fda3054/packages/core/src/lib/template/template.interface.ts#L43

@scopsy
Copy link
Contributor Author

scopsy commented Nov 16, 2021

@devblin for now let's leave the inline attachments out of the scope of this issue and just focus on regular attachments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers @notifire/mailjet
Projects
None yet
Development

No branches or pull requests

3 participants