Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NV-1677] Feature: Manage unused jobs of merged digests #2760

Closed
p-fernandez opened this issue Feb 14, 2023 · 1 comment
Closed

[NV-1677] Feature: Manage unused jobs of merged digests #2760

p-fernandez opened this issue Feb 14, 2023 · 1 comment
Assignees
Labels
Cool Down Created by Linear-GitHub Sync Medium priority Created by Linear-GitHub Sync polishing Created by Linear-GitHub Sync Technical Debt Created by Linear-GitHub Sync

Comments

@p-fernandez
Copy link
Contributor

p-fernandez commented Feb 14, 2023

📜 Description

After fixing the race conditions in: https://linear.app/novu/issue/NV-1561/%F0%9F%90%9B-bug-report-duplicate-emails-when-using-digest

the change of logic makes to have jobs steps that are unused and we want to manage them properly and not leave them as pending as that could either create side effects on other features or skew the statistics.

For that we need to add logic in the trigger event flow to set those job steps that belong to merged digest jobs as digested or merged. That means to create a new StepStatusEnum entry that marks them properly (name to be agreed).

From SyncLinear.com | NV-1677

@p-fernandez p-fernandez self-assigned this Feb 14, 2023
@p-fernandez p-fernandez added bug Something isn't working High priority Created by Linear-GitHub Sync polishing Created by Linear-GitHub Sync labels Feb 14, 2023
@p-fernandez p-fernandez changed the title [NV-1677] 🐛 Feature: Manage unused jobs of merged digests [NV-1677] Feature: Manage unused jobs of merged digests Feb 14, 2023
@p-fernandez p-fernandez added Medium priority Created by Linear-GitHub Sync and removed High priority Created by Linear-GitHub Sync labels Feb 26, 2023
@p-fernandez p-fernandez added Cool Down Created by Linear-GitHub Sync bug Something isn't working Technical Debt Created by Linear-GitHub Sync and removed bug Something isn't working labels Mar 15, 2023
@oba2311
Copy link
Contributor

oba2311 commented Mar 15, 2023

@p-fernandez as there is no effect AFAIK on the user experience, we consider it a tech debt for now but if you think otherwise would love to discuss further.

In general we need to chat a bit on the effort for digest as there are several moving parts and we can prioritize (next cycle prob).

@p-fernandez p-fernandez removed the bug Something isn't working label Mar 15, 2023
@p-fernandez p-fernandez modified the milestone: Cycle 29 Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cool Down Created by Linear-GitHub Sync Medium priority Created by Linear-GitHub Sync polishing Created by Linear-GitHub Sync Technical Debt Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

3 participants