-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃摎 Docs Feedback: Instructions not clear after spinning docker-compose.yml for development #4597
Comments
@Himanshupal0001 did you find out about our local development guide? https://docs.novu.co/community/run-in-local-machine |
@p-fernandez Could you please assign this issue to me? I would like to work on providing clearer instructions for using the development compose file |
This commit addresses issue novuhq#4597 where contributors faced challenges setting up a development environment for web development in Novu. The issue highlighted a lack of clear instructions in the CONTRIBUTING.md file on how to spin the Docker container and access different repositories after running the docker-compose.yml file. To resolve this, the commit includes additional instructions in CONTRIBUTING.md, specifically focusing on clarifying the steps to access the web, API, and worker repositories after successfully running the docker-compose.yml file. These changes aim to improve the onboarding experience for contributors interested in frontend and API development/testing. issue novuhq#4597
Hey @Himanshupal0001, Could you please elaborate what were the issue you faced and what were your intentions? it could help the assigned contributor to understand the pain and how to solve it. After spinning the project i think looking into the structure of the project could help to understand it better |
Hello! I appreciate your reference link to the monorepo structure documentation. While reviewing it, I found that it provided useful insights into the general structure of Novu. However, regarding the specific issue I encountered鈥攕etting up the development environment and accessing different repositories after running Docker containers鈥攖here seemed to be a gap in the documentation. To address this, I've made updates to the |
@p-fernandez and @djabarovgeorge |
Yes I read it thoroughly. What I understood from this doc is how to run novu development environment locally on developer machine, which means the developer needs to install all the dependencies in the local machine and then start the development. My issue is that what if not every developer wants to install all the dependencies locally? Maybe they want to keep the novu and their local environment separate. Thus they need a docker container to run novu dev env . While trying to run the docker container of novu, I've encountered two scenarios. **1. Devcontainer - ** I ran the devcontainer on the vs code and it worked but it consumes lot of resources from my local machine and I was not able to work on my other tasks. Below are the pros and cons I found about devcontainer. Pros
Cons
**2. Docker container - ** As mentioned in the issue I found the docker conpose file and spin it locally. It was running fine but I was not able to run frontend of novu. After deep diving I found there are three containers running which are localstack, mongo and redis. Now the issue is there is not clear instructions how
|
Have you tried to run frontend application? |
@Himanshupal0001 |
Duplicates
Related page
https://github.com/novuhq/novu/tree/next/docker/local/development
Kind of issue
Missing information
Issue description
I was trying to create development environment to work on web but there was no clear instructions on contribution.md how to spin the docker container and work on the different repos. There is only single link https://docs.novu.co/community/run-in-local-machine how to setup novu locally.
After trying I found the docker-compose.yml file in root->docker->local->development->docker-compose.yml. The docker-compose is running but after that there is not clear instructions how to access web, api, workers and other repos for contributions. In terminal it is clear that localstack, mongodb and redis is running. But I am not sure how to access web repo for development.
![py1](https://private-user-images.githubusercontent.com/49358057/276909072-2ed83509-20c4-4a7c-843a-8d128a228c07.PNG?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk3NTAyMjksIm5iZiI6MTcxOTc0OTkyOSwicGF0aCI6Ii80OTM1ODA1Ny8yNzY5MDkwNzItMmVkODM1MDktMjBjNC00YTdjLTg0M2EtOGQxMjhhMjI4YzA3LlBORz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MzAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjMwVDEyMTg0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTczOWE1ZjA3NDhkNWFkYjg3NWYwNDdiMGYxODA3MjYzZGRjODRmZmZlOTIyOTNiYTcxZGM0ODJhYzM5YzAzNTImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.cgqDi7fRmVkDVC6dcw5bXCTwyeDplriVEVpLHhaKMRQ)
There is no clear instructions how to use development compose file for development and to do after that.
![py2](https://private-user-images.githubusercontent.com/49358057/276909606-8fec8698-fa5e-4217-a505-811ca9ddb009.PNG?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk3NTAyMjksIm5iZiI6MTcxOTc0OTkyOSwicGF0aCI6Ii80OTM1ODA1Ny8yNzY5MDk2MDYtOGZlYzg2OTgtZmE1ZS00MjE3LWE1MDUtODExY2E5ZGRiMDA5LlBORz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MzAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjMwVDEyMTg0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTAxOTVkZmQzYTU1YzUxNWI1ODIyOTQ5NTI0YzZmMTMzMTNiMzBjNDU1ZDUwM2Q5NmMxYjNkOGU2YmVkNDIxYmMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.1aeIlL4wOe3h-7b1KszdUvQ2DPW6jl1hwPGtJN1KCP4)
Context 馃敠
I am interested in contributing frontend development and api development/testing but I don't want to install everything on my local machine. I was looking for decker image to run the code but there is no relevant document nor topics to go through.
The text was updated successfully, but these errors were encountered: