Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NV-767] - Switch deprecated faker.name.title function to jobTitle #1017

Merged
merged 1 commit into from Aug 12, 2022
Merged

[NV-767] - Switch deprecated faker.name.title function to jobTitle #1017

merged 1 commit into from Aug 12, 2022

Conversation

Rutam21
Copy link
Contributor

@Rutam21 Rutam21 commented Aug 12, 2022 •
edited by novubot

Why?

Faker.js has deprecated faker.name.title in favor of the jobTitle.

What?

Update all the place that used faker.name.title to the new method.

@vercel
Copy link

vercel bot commented Aug 12, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs ✅ Ready (Inspect) Visit Preview Aug 12, 2022 at 6:26AM (UTC)

@Rutam21
Copy link
Contributor Author

Rutam21 commented Aug 12, 2022

@scopsy Please review and suggest changes, if any.

davidsoderberg
davidsoderberg approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@davidsoderberg davidsoderberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help 👍

@davidsoderberg davidsoderberg merged commit 29cb420 into novuhq:main Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsoderberg davidsoderberg davidsoderberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rutam21 @davidsoderberg