Added Sendinblue as a provider #111
Conversation
Co-authored-by: Dima Grossman <dima@grossman.io>
Update quick-start.md
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/dimagrossman/docs/HNGPNtZXDhRJBRXa28eAqMKd3R2i [Deployment for e9b2d01 canceled] |
|
From a quick pick look amazing @galezra ! I'll take a closer look in the near couple of days. Do you want maybe to already add the attachments support? Just merge from v0.3.0 and move your pr to point to it instead of master. |
|
Sure, I'll add the attachment support and resolve the conflicts |
|
@galezra This looks great just waiting on the attachments and we can merge :) |
* Add a direct message interface * Fix lint error for short hand property * Update content.engine.ts * Update direct.handler.ts
Added nestjs module for notifire
Done |
| email.textContent = options.text; | ||
| email.attachment = options.attachments?.map((attachment) => ({ | ||
| name: attachment?.name, | ||
| content: attachment?.file?.toString('utf8'), |
There was a problem hiding this comment.
@galezra Have you tried doing a test case of sending it here? I'm not sure about the utf8 string here, in the docs looks like they say it should be either a relative path or a base64 encoding. ( https://github.com/sendinblue/APIv3-nodejs-library/blob/master/docs/SendSmtpEmail.md )
If you haven't tried it our I can maybe create a free account there later to try and see if the attachments are sent and can be opened on the other side.
|
@scopsy You're right, |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Added SendinBlue as a provider.
What is the current behavior? (You can also link to an open issue here)
Add new SendinBlue provider #79
What is the new behavior (if this is a feature change)?
Use SendinBlue as a email provider
Other information:
Used the SendinBlue typescript repo to create the provider