Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the externalUrlRegex param for Algolia #1185

Merged
merged 1 commit into from Sep 4, 2022

Conversation

andrewgolovanov
Copy link
Member

@andrewgolovanov andrewgolovanov commented Sep 2, 2022

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Docs update: This pull request adds the externalUrlRegex param for Algolia.
  • What is the current behavior? (You can also link to an open issue here)
    When you go to a page from the documentation search, we get to a page that does not exist
  • What is the new behavior (if this is a feature change)?
    This option allows for window.location instead of history.push. Which solves the problem with links for API documentation. You can find more about this here
  • Other information:
    N/A

@scopsy scopsy merged commit c9f22a9 into novuhq:main Sep 4, 2022
@andrewgolovanov andrewgolovanov deleted the update-algolia-config branch September 5, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants