Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SES attachments support #129

Merged
merged 3 commits into from
Dec 6, 2021
Merged

Conversation

galezra
Copy link
Contributor

@galezra galezra commented Nov 29, 2021

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Feature request: SES attachments support #98

  • What is the current behavior? (You can also link to an open issue here)
    No support for file attachments.

  • What is the new behavior (if this is a feature change)?
    SES provider now supports attachments.

  • Other information:
    The feature hasn't been tested yet, we need to validate the transporter through nodemailer

@vercel
Copy link

vercel bot commented Nov 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/dimagrossman/docs/Ev5qv41CsfPMZiFQkAkSZG4ZLaVQ
✅ Preview: Canceled

[Deployment for a2a3a91 canceled]

@galezra galezra changed the title SES attachments support Added SES attachments support Nov 29, 2021
@scopsy
Copy link
Contributor

scopsy commented Dec 5, 2021

@galezra the nodemailer approach just wasn't working for me :(

Replace it with email.js to generate the raw message and used the aws-ses, not the v2 one. Tested it locally with a valid SES key and seems to work 🎉

Let me know what you think

@scopsy scopsy marked this pull request as ready for review December 5, 2021 19:47
@galezra
Copy link
Contributor Author

galezra commented Dec 5, 2021

It looks awesome! 3.0 🙌🏼

@scopsy scopsy merged commit 27d3a06 into novuhq:v0.3.0 Dec 6, 2021
@scopsy scopsy linked an issue Dec 6, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SES attachments support
2 participants