feat(nexmo.js): add support for Nexmo/Vonage SMS #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranrib
commented
Dec 15, 2021
providers/nexmo/README.md
Outdated
| @@ -0,0 +1,15 @@ | |||
| # Notifire Nexmo Provider | |||
|
|
|||
| A Nexmo sns provider library for [@notifire/core](https://github.com/notifirehq/notifire) | |||
There was a problem hiding this comment.
Actually sns seems like the boilerplate bug @scopsy
scopsy
reviewed
Dec 15, 2021
| options.content, | ||
| {}, | ||
| (err, responseData) => { | ||
| if (err) reject(err); |
There was a problem hiding this comment.
Suggested change
| if (err) reject(err); | |
| if (err) return reject(err); |
Missing a return here :)
| from: string; | ||
| } | ||
| ) { | ||
| this.vonageClient = new Vonage({apiKey: config.apiKey, apiSecret: config.apiSecret}); |
There was a problem hiding this comment.
Could you please run prettier in this file? 💅 @matthiez is taking a look at why it's not working on the precommit hook
providers/nexmo/README.md
Outdated
| @@ -0,0 +1,15 @@ | |||
| # Notifire Nexmo Provider | |||
|
|
|||
| A Nexmo sns provider library for [@notifire/core](https://github.com/notifirehq/notifire) | |||
Closed
Closed
|
|
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/dimagrossman/docs/GMLvgrzKCPPdkVt1bHnFwYja2kgv |
|
All fixed @scopsy |
scopsy
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Supports Vonage/Nexmo SMS
What is the current behavior? (You can also link to an open issue here)
implements Add new Nexmo provider #26
What is the new behavior (if this is a feature change)?
Other information: