Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: i18n support for marathi #1416

Merged
merged 2 commits into from Oct 4, 2022
Merged

feat: i18n support for marathi #1416

merged 2 commits into from Oct 4, 2022

Conversation

asmitbm
Copy link
Contributor

@asmitbm asmitbm commented Oct 4, 2022 •
edited

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    This PR adds Marathi Language support for Novu.

  • Why this change was needed? (You can also link to an open issue here)
    This PR fixes: i18n - Marathi Support #1367

@p-fernandez
Copy link
Contributor

This is a duplicate of: #1376
Also the language ISO code seems to be wrong. Should be MR according https://www.loc.gov/standards/iso639-2/php/langcodes_name.php?iso_639_1=mr.

@p-fernandez p-fernandez added the duplicate This issue or pull request already exists label Oct 4, 2022
@asmitbm
Copy link
Contributor Author

asmitbm commented Oct 4, 2022

This is a duplicate of: #1376
Also the language ISO code seems to be wrong. Should be MR according https://www.loc.gov/standards/iso639-2/php/langcodes_name.php?iso_639_1=mr.

Hey @p-fernandez I had opened the issue on the repository and I was working on it. Could you assign this to me?

@asmitbm
Copy link
Contributor Author

asmitbm commented Oct 4, 2022

Here #1367

@asmitbm
Copy link
Contributor Author

asmitbm commented Oct 4, 2022

Hey @p-fernandez resolved the issues, can you now check this PR?

scopsy
scopsy approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@scopsy scopsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your contribution! Really appreciate it 🙏

@scopsy scopsy merged commit 79d444f into novuhq:main Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scopsy scopsy scopsy approved these changes

Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

i18n - Marathi Support
3 participants
@asmitbm @p-fernandez @scopsy