Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(i18n): add km(Khmer) language #1566

Merged
merged 2 commits into from Oct 10, 2022
Merged

feat(i18n): add km(Khmer) language #1566

merged 2 commits into from Oct 10, 2022

Conversation

munyoudoum
Copy link
Contributor

@munyoudoum munyoudoum commented Oct 8, 2022 •
edited

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    feature: add Khmer language
  • Why was this change needed? (You can also link to an open issue here)
    Closes 🚀 Feature: i18n Khmer language #1561
  • Other information:

akshitagupta15june
akshitagupta15june reviewed Oct 10, 2022
View reviewed changes
Copy link
Contributor

@akshitagupta15june akshitagupta15june left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey is km(Khmer) your native language?

@munyoudoum
Copy link
Contributor Author

Hey is km(Khmer) your native language?

@akshitagupta15june yes

@akshitagupta15june
Copy link
Contributor

@scopsy Khmer is in ISO 639-1

p-fernandez
p-fernandez approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@p-fernandez p-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@p-fernandez p-fernandez merged commit efe9fe3 into novuhq:main Oct 10, 2022
@munyoudoum munyoudoum deleted the feat/language/km branch October 11, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshitagupta15june akshitagupta15june akshitagupta15june left review comments

@p-fernandez p-fernandez p-fernandez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 Feature: i18n Khmer language
3 participants
@munyoudoum @akshitagupta15june @p-fernandez