Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored a punctuation mark #1628

Merged
merged 1 commit into from Oct 11, 2022
Merged

Refactored a punctuation mark #1628

merged 1 commit into from Oct 11, 2022

Conversation

Srikarmk
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Changed a semicolon into a comma for grammatical reasons.
  • Why was this change needed? (You can also link to an open issue here)
    To improve readability and clarity
  • Other information:
    Thanks for your patience @scopsy .

Copy link
Contributor

@scopsy scopsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your contribution! Really appreciate it 🙏

@scopsy scopsy merged commit 76f85a2 into novuhq:main Oct 11, 2022
@Srikarmk
Copy link
Contributor Author

Thank you for accepting it !!!

Copy link

@EmmaDawsonDev EmmaDawsonDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a semi-colon is correct so no need for this change.

@Srikarmk
Copy link
Contributor Author

Using a semi-colon is correct so no need for this change.

It doesn't exactly join or divide the sentence , a comma or hyphen would be effective grammatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants