NX Workspaces Support #165
Conversation
|
|
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/dimagrossman/docs/JAeHZ7B1QmLaHh8Xww6fkxhfDLh4 |
| @@ -69,7 +70,10 @@ | |||
| "lint-staged": "^10.2.2", | |||
| "monorepo-run": "git+https://github.com/scopsy/monorepo-run.git", | |||
| "prettier": "^2.0.5", | |||
| "rimraf": "^3.0.2" | |||
| "rimraf": "^3.0.2", | |||
| "@nrwl/workspace": "latest", | |||
There was a problem hiding this comment.
@nishit-g is that the nx convention? Maybe it's better if we will pin this to a specific version?
| @@ -2,6 +2,7 @@ | |||
| "name": "notifirehq", | |||
| "private": true, | |||
| "scripts": { | |||
| "nx:build": "pnpm nx run-many --target=build --all", | |||
There was a problem hiding this comment.
I think we can change the build we currently have instead of adding a specific command for that. Another not really related task, is that maybe we can add pnpm as a devDependency to the package.json file so we don't need to prefix with pnpm inside the scripts section in package.json
| "config": { | ||
| "commitizen": { | ||
| "path": "cz-conventional-changelog" | ||
| } | ||
| }, |
There was a problem hiding this comment.
Good catch on updating all the packages with the new .czrc! 😍
|
Incredible job @nishit-g ! Looks very clean and works perfectly on my tests 🎉 |
|
@nishit-g I'll merge this for now, really want to start playing with it. So I will fix the small comments I mentioned in the review. Incredible work and super exciting 🤩 |
|
@scopsy was just about to push the new changes! |
|
@nishit-g Oh sorry! Push them, i'll merge again. Create a new PR for it from the same branch. |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature: NX workspaces support [Tracking] NX workspaces support #164
What is the current behavior? (You can also link to an open issue here)
lerna builds the packages
What is the new behavior (if this is a feature change)?
NX builds the all the packages
Other information:
Please test to confirm if commitizen is working or not as the "config" key from different packages/libs/providers have been moved to .czrc file in their respective directory.