feat: mailersend check integration function #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-fernandez
reviewed
Oct 17, 2022
Comment on lines
91
to
95
| .mockImplementation(() => | ||
| Promise.resolve({ | ||
| ok: true, | ||
| status: 200, | ||
| }) |
There was a problem hiding this comment.
Suggested change
| .mockImplementation(() => | |
| Promise.resolve({ | |
| ok: true, | |
| status: 200, | |
| }) | |
| .mockImplementation(async () => ({ | |
| ok: true, | |
| status: 200, | |
| }) |
Just to unify the style of the spies as the implemented ones in this file followed async/await syntax.
There was a problem hiding this comment.
Agree with you!
Comment on lines
114
to
122
| .mockImplementation(() => | ||
| Promise.resolve({ | ||
| ok: false, | ||
| json: () => | ||
| Promise.resolve({ | ||
| message: serverMessage, | ||
| }), | ||
| status: 401, | ||
| }) |
There was a problem hiding this comment.
Let's unify the style of the spies as the implemented ones in this file followed async/await syntax.
Comment on lines
25
to
27
| private createRecipients( | ||
| recipients: IEmailOptions['to'] | ||
| ): Recipient[] | Recipient { |
There was a problem hiding this comment.
Suggested change
| private createRecipients( | |
| recipients: IEmailOptions['to'] | |
| ): Recipient[] | Recipient { | |
| private createRecipients( | |
| recipients: IEmailOptions['to'] | |
| ): Recipient[] { |
We are returning an array always.
There was a problem hiding this comment.
Wow, good you noticed it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature: implemented
checkIntegrationfor mailersendWhy was this change needed?
Resolves [NV-988] - Test MailerSend provider connection when creating/updating integration #1648
Other information: