New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added a detailed PR Template #1866
Conversation
I think it's a good addition, rest up to you :) |
Hi @MrKrishnaAgarwal Thanks for the PR : What I think would be good to add is maybe some text under the "other information" heading we have today is that we would appreciate if screenshots was provided of UI changes, what do you think @MrKrishnaAgarwal, @ainouzgali @p-fernandez @djabarovgeorge @BiswaViraj ? |
and I think the UI changes screenshot can be added by the user under the Screenshots section |
I think most of it is not needed because the stuff mentioned in my first comment but we might add some text in the current "other information" section about screenshots 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address @davidsoderberg comments.
Okay Sure! |
4dda366
to
d7691f3
Compare
@davidsoderberg @p-fernandez I have resolved all the things and updated accordingly. |
@ainouzgali and @scopsy Can you review the PR and merge it! |
thankyou @ainouzgali ✨ |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature, Docs
Why was this change needed? (You can also link to an open issue here)
This change was needed because I think a detailed PR template would be better and is a good option both for maintainers and contributors
Other information:
Any suggestions and improvements are welcome!
cc @scopsy