Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed duplicate entry and corrected alphabetical order #1871

Merged
merged 2 commits into from Oct 28, 2022
Merged

removed duplicate entry and corrected alphabetical order #1871

merged 2 commits into from Oct 28, 2022

Conversation

omimakhare
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    made all language codes alphabetically correct.
    also removed the duplicate entry of language code da from line number 201 and 209.

  • Why was this change needed? (You can also link to an open issue here)
    While all language codes were placed randomly it was possible for an duplicate entry.
    its not a big issue to have duplicate entry but it is good practice to avoid it. so removed duplicate entry of da.

made all language codes alphabetically correct.
also removed the duplicate entry of language code da from line number 201 and 209.
Copy link
Contributor

@p-fernandez p-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are an absolute legend.
🌟

@omimakhare
Copy link
Contributor Author

Is there any problem to merge this PR. if so please tell me.
I am participating in HACKSQUAD event and merge of PR is must for, so please merge it asap if possible.
Thank you.

@davidsoderberg davidsoderberg merged commit a683710 into novuhq:main Oct 28, 2022
@omimakhare omimakhare deleted the patch-3 branch October 28, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants