Feat migrate mantine notification center #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-notification-center
p-fernandez
reviewed
Nov 11, 2022
| tabsList: { | ||
| gap: '30px', | ||
| padding: '15px', | ||
| paddingBottom: 0, | ||
| borderBottom: '1px solid ' + (colorScheme === 'dark' ? colors.B20 : colors.B98), |
There was a problem hiding this comment.
Suggested change
| borderBottom: '1px solid ' + (colorScheme === 'dark' ? colors.B20 : colors.B98), | |
| borderBottom: `1px solid ${colorScheme === 'dark' ? colors.B20 : colors.B98}`, |
|
|
github-actions
bot
added
@novu/api
@novu/dal
@novu/shared
@novu/web
@novu/webhook
@novu/ws
documentation
…nto feat-migrate-mantine-notification-center
github-actions
bot
removed
providers
documentation
scopsy
approved these changes
Nov 14, 2022
There was a problem hiding this comment.
Looks great! I think we can merge this for now, I believe we will revisit parts of this in the next release too combining the notification center abstraction @LetItRock will work on.
LetItRock
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.