feat: add socket event notification_received #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scopsy
reviewed
Dec 21, 2022
Comment on lines
+184
to
+190
| await this.queueService.wsSocketQueue.add({ | ||
| event: 'notification_received', | ||
| userId: command.subscriberId, | ||
| payload: { | ||
| message, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
Is this the only place where this needed to be added? Did you had a chance to test it with the iframe embed or the useSocket from react?
There was a problem hiding this comment.
Yes what I can see this is the only place we need to add it.
There was a problem hiding this comment.
And yes I have test it with useSocket 😄
BiswaViraj
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Add a new socket event when a notification is created
Why was this change needed?
Closing #1220