Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nv 1239 bug report unable to remove cta buttons #2342

Merged
merged 4 commits into from
Dec 29, 2022

Conversation

BiswaViraj
Copy link
Contributor

What change does this PR introduce?

Why was this change needed?

Other information (Screenshots)

Screen.Recording.2022-12-22.at.5.04.09.PM.mov

@linear
Copy link

linear bot commented Dec 22, 2022

NV-1239 🐛 Bug Report: unable to remove CTA buttons inside in-app editor

📜 Description

The CTA buttons doesnt get removed upon removing them from UI and updating it,
Upon reloading the page after the update, the CTA button appears again

👟 Reproduction steps

  1. Open in-app editor
  2. add CTA buttons
  3. update to save the buttons
  4. remove the CTA buttons from the UI using the x icon
  5. update it again to save the changes
  6. reload or revisit the page
  7. The CTA buttons appears again.

👍 Expected behavior

It should delete the CTA button upon removal

👎 Actual Behavior with Screenshots

Screen.Recording.2022-11-06.at.7.43.10.PM.mov

💻 Operating system

MacOS

🤖 Node Version

N/A

📃 Provide any additional context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to submit PR?

No response

@scopsy
Copy link
Contributor

scopsy commented Dec 25, 2022

@BiswaViraj can we add a test to cover this functionality too?

@BiswaViraj BiswaViraj force-pushed the nv-1239-bug-report-unable-to-remove-cta-buttons branch from 98def8f to 8f49aa5 Compare December 26, 2022 12:40
Copy link
Contributor

@LetItRock LetItRock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me ;)

@BiswaViraj BiswaViraj merged commit 7b7dadc into next Dec 29, 2022
@BiswaViraj BiswaViraj deleted the nv-1239-bug-report-unable-to-remove-cta-buttons branch December 29, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants