fix: should not save system variables to trigger #2363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BiswaViraj
reviewed
Dec 27, 2022
| @@ -77,6 +87,10 @@ export class ContentService { | |||
| } | |||
| } | |||
|
|
|||
| private isSystemVariable(variableName: string): boolean { | |||
| return TemplateSystemVariables.includes(variableName.includes('.') ? variableName.split('.')[0] : variableName); | |||
There was a problem hiding this comment.
Suggested change
| return TemplateSystemVariables.includes(variableName.includes('.') ? variableName.split('.')[0] : variableName); | |
| const variable = variableName.includes('.') ? variableName.split('.')[0] : variableName | |
| return TemplateSystemVariables.includes(variable); |
I feel this will be much clearer to read
There was a problem hiding this comment.
I am actually not sure I agree🙈 For me its easier having that context in the same line
But I don't mind changing it if you feel strongly about it :) @BiswaViraj
There was a problem hiding this comment.
No, it's okay, just a personal preference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Fix so system variables (step, subscriber etc) are not saved to trigger => not shown as variables in the trigger snippet that user can apply values to them
Why was this change needed?
Other information (Screenshots)