Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass credentials to the provider #2368

Merged
merged 1 commit into from
Dec 26, 2022

Conversation

BiswaViraj
Copy link
Contributor

What change does this PR introduce?

Why was this change needed?

Pass the integration credentials to the builder to fix Twilio error

Other information (Screenshots)

@linear
Copy link

linear bot commented Dec 26, 2022

NV-1403 Error: username is required

Sentry Issue: API-4X

Error: username is required
  File "/usr/src/app/node_modules/.pnpm/twilio@3.76.0/node_modules/twilio/lib/rest/Twilio.js", line 139, col 11, in new Twilio
    throw new Error('username is required');
  File "/usr/src/app/providers/twilio/build/main/lib/twilio.provider.js", line 47, col 29, in new TwilioSmsProvider
    this.twilioClient = new twilio_1.Twilio(config.accountSid, config.authToken);
  File "/usr/src/app/packages/application-generic/build/main/factories/sms/handlers/twilio.handler.js", line 33, col 25, in TwilioHandler.buildProvider
    this.provider = new twilio_1.TwilioSmsProvider(config);
  File "/usr/src/app/apps/api/dist/webpack:/@novu/api/src/app/integrations/usecases/get-webhook-support-status/get-webhook-support-status.usecase.ts", line 61, col 13, in GetWebhookSupportStatus.createProvider
  File "/usr/src/app/apps/api/dist/webpack:/@novu/api/src/app/integrations/usecases/get-webhook-support-status/get-webhook-support-status.usecase.ts", line 31, col 10, in GetWebhookSupportStatus.<anonymous>
  File "/usr/src/app/node_modules/.pnpm/twilio@3.76.0/node_modules/twilio/lib/rest/Twilio.js", in Generator.next
  File "/usr/src/app/apps/api/dist/main.js", line 24966, col 58, in fulfilled
    function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
  File "/usr/src/app/node_modules/.pnpm/twilio@3.76.0/node_modules/twilio/lib/rest/Twilio.js", in runMicrotasks
  File "node:internal/process/task_queues", line 96, col 5, in processTicksAndRejections

@BiswaViraj BiswaViraj merged commit 3d93219 into next Dec 26, 2022
@BiswaViraj BiswaViraj deleted the nv-1403-error-username-is-required branch December 26, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants