chore(notification-center): fix for ssr issues #2395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LetItRock
commented
Dec 30, 2022
| @@ -77,6 +77,7 @@ | |||
| "axios": "^0.26.1", | |||
| "chroma-js": "^2.4.2", | |||
| "date-fns": "^2.29.1", | |||
| "lodash.clonedeep": "^4.5.0", | |||
There was a problem hiding this comment.
lodash.clonedeep is used instead of structuredClone which is only available rn in the browser (web API)
| @@ -17,6 +17,7 @@ export default [ | |||
| file: packageJson.main, | |||
| format: 'cjs', | |||
| sourcemap: true, | |||
| interop: 'auto', | |||
There was a problem hiding this comment.
The main issue was with the @emotion/styled which exports the styled.div functions in the default export, which works in the ESM module, but not in CJS which natively doesn't support it well.
The option from the docs:
Controls how Rollup handles default, namespace and dynamic imports from external dependencies in formats like CommonJS that do not natively support these concepts.
"auto" combines both "esModule" and "default" by injecting helpers that contain code that detects at runtime if the required value contains the [__esModule property](https://rollupjs.org/guide/en/#outputesmodule).
Comment on lines
+103
to
+105
| if (isSSR) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
we are in the react to web component proxy file
when it's used during SSR just do nothing, because the Web APIs do not exist on server side
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
It fixes a couple of issues related to running the
notification-centerpackage in the SSR app.The Discord thread: https://discord.com/channels/895029566685462578/1057740995321663689
Why was this change needed?
To allow SSR-rendered apps use the
notification-centerpackage.Other information (Screenshots)