feat(dal): add relationship between message template and layout #2444
Conversation
NV-1422 Feature: add relationship between Message Template and Layout
DAL relationship to MessageTemplate and Layout. |
p-fernandez
force-pushed
the
nv-1422-feature-add-relationship-between-message
branch
from
281d85f
to
6ed8aea
Compare
p-fernandez
force-pushed
the
nv-1422-feature-add-relationship-between-message
branch
from
6ed8aea
to
00f9ce4
Compare
| @@ -11,6 +11,9 @@ export class MessageTemplateEntity { | |||
|
|
|||
| _creatorId: string; | |||
|
|
|||
| // TODO: Due a circular dependency I can't import LayoutId from Layout. | |||
| _layoutId: string | null; | |||
There was a problem hiding this comment.
This line export { IEmailBlock, ITemplateVariable } from '../message-template'; shouldn't be exported from the libs/dal/src/repositories/layout/types.ts. Just import it directly, because this way it creates a circular dependency.
ex. file libs/dal/src/repositories/layout/layout.entity.ts should import IEmailBlock from ../message-template or another suggestion to move these types to some shared folder...
There was a problem hiding this comment.
I want to review the types and do some tidy up. Will do it in a different PR and I will address this problem. Mainly I was facing that message-template and layout are dependant on each other (because sharing properties and the relationship through LayoutId). Tidying up types should help for that. 🙂
p-fernandez
deleted the
nv-1422-feature-add-relationship-between-message
branch
What change does this PR introduce?
Adds the relationship at DAL level for Message Template and Layout. Also adds missing test in message template creation to validate the change.
Why was this change needed?
Another step forward for the DAL for Layouts feature.
Other information (Screenshots)