fix: duplicate preference rows on update #2450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ainouzgali
requested review from
LetItRock,
davidsoderberg,
djabarovgeorge and
scopsy
|
@ainouzgali could we create a test to make sure it won't happen again? Initially was thinking it was a backend issue actually |
LetItRock
approved these changes
Jan 10, 2023
|
Update on the tests - I'm having trouble reproducing through cypress. |
scopsy
pushed a commit
that referenced
this pull request
Jan 13, 2023
…-update fix: duplicate preference rows on update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
After update the search by index was not identical - it would override a different record.
Why was this change needed?
Closes: #2436
Other information (Screenshots)