Feature/dynamic onboarding #2456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add blueprint modal and env for blueprint org
feat: add usecase to calculate if predefined provider should be used
scopsy
reviewed
Jan 10, 2023
scopsy
reviewed
Jan 11, 2023
| import { CreateBlueprintNotificationTemplateCommand } from './create-blueprint-notification-template.command'; | ||
|
|
||
| @Injectable() | ||
| export class CreateBlueprintNotificationTemplate { |
There was a problem hiding this comment.
A small question. can we use the same create template endpoint and based on the requested organization mark it as blueprint? Do we need to have a separate usecase for this?
There was a problem hiding this comment.
Oh, or is it when a user creates a new blueprint? (by clicking on the modal?)
There was a problem hiding this comment.
ah this is creating a notification template from a a blueprint...
scopsy
reviewed
Jan 11, 2023
apps/api/src/app/notification-template/notification-template.controller.ts
Outdated
Show resolved
Hide resolved
ainouzgali
reviewed
Jan 12, 2023
.../app/execution-details/usecases/create-execution-details/create-execution-details.command.ts
Outdated
Show resolved
Hide resolved
apps/api/src/app/integrations/usecases/get-novu-integration/get-novu-integration.usecase.ts
Show resolved
Hide resolved
...ses/create-blueprint-notification-template/create-blueprint-notification-template.usecase.ts
Show resolved
Hide resolved
scopsy
approved these changes
Jan 12, 2023
...change/usecases/promote-notification-template-change/promote-notification-template-change.ts
Outdated
Show resolved
Hide resolved
…-change/promote-notification-template-change.ts Co-authored-by: Dima Grossman <dima@grossman.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
collecting branch for predefined provider and dynamic onboarding