feat(api): run step filters - is online logic #2472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NV-1434 Implement the functionality that will run online filters logic
Changes will need to be applied here |
LetItRock
commented
Jan 11, 2023
Comment on lines
+575
to
+579
| const matcher = new MessageMatcher( | ||
| { findOne: () => Promise.resolve(getSubscriber()) } as any, | ||
| undefined as any, | ||
| undefined as any | ||
| ); |
There was a problem hiding this comment.
I couldn't find a better way how to pass a mocked SubscriberRepository instance with Sinon to the MessageMatcher, so decided to do that this way.
| @@ -27,7 +27,7 @@ const subscriberSchema = new Schema( | |||
| type: Schema.Types.Boolean, | |||
| default: false, | |||
| }, | |||
| lastOnlineAt: Schema.Types.String, | |||
| lastOnlineAt: Schema.Types.Date, | |||
There was a problem hiding this comment.
in DB we do store it as a date
Comment on lines
+145
to
+148
| const isOnlineMatch = subscriber?.isOnline === filter.value; | ||
| if (filter.on === 'isOnline') { | ||
| return isOnlineMatch; | ||
| } |
There was a problem hiding this comment.
for the isOnline filter we just do check if the isOnline value on the subscriber matches with the filter value
Comment on lines
+150
to
+154
| const currentDate = new Date(); | ||
| const lastOnlineAt = subscriber?.lastOnlineAt ? parseISO(subscriber?.lastOnlineAt) : new Date(); | ||
| const diff = differenceIn(currentDate, lastOnlineAt, filter.timeOperator); | ||
|
|
||
| return subscriber?.isOnline || (!subscriber?.isOnline && diff <= filter.value); |
There was a problem hiding this comment.
for the isOnlineInLast we do check:
- if the subscriber is online
- or if the subscriber is offline but was online in the last X minutes, hours, days
…is-online-filters-logic
…is-online-filters-logic
…is-online-filters-logic
Base automatically changed from
nv-1432-update-types-for-step-filter
to
nv-1441-is-online-filters-feature
January 11, 2023 16:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Implemented the step filters logic for the "Is Online Filters".
Why was this change needed?
This is a part of the "Is Online Filters" functionality.
Other information (Screenshots)