-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nv 1464 web create layout page #2474
Merged
ainouzgali
merged 5 commits into
NV-1409-Web---add-Layout-page
from
nv-1464-web-create-layout-page
Jan 12, 2023
Merged
Nv 1464 web create layout page #2474
ainouzgali
merged 5 commits into
NV-1409-Web---add-Layout-page
from
nv-1464-web-create-layout-page
Jan 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto nv-1464-web-create-layout-page
ainouzgali
changed the base branch from
NV-1409-Web---add-Layout-page
to
feat-layouts
January 11, 2023 12:04
ainouzgali
changed the base branch from
feat-layouts
to
NV-1409-Web---add-Layout-page
January 11, 2023 12:05
…nto nv-1464-web-create-layout-page
p-fernandez
approved these changes
Jan 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but let's review at least the logic thing, please.
🌟
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Add get layout and create layout
Why was this change needed?
Other information (Screenshots)
Will create types in shared in a future pr, when we have all endpoints