Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nv 1464 web create layout page #2474

Merged

Conversation

ainouzgali
Copy link
Contributor

What change does this PR introduce?

Add get layout and create layout

Why was this change needed?

Other information (Screenshots)

Will create types in shared in a future pr, when we have all endpoints

@linear
Copy link

linear bot commented Jan 11, 2023

@ainouzgali ainouzgali changed the base branch from NV-1409-Web---add-Layout-page to feat-layouts January 11, 2023 12:04
@ainouzgali ainouzgali changed the base branch from feat-layouts to NV-1409-Web---add-Layout-page January 11, 2023 12:05
Copy link
Contributor

@p-fernandez p-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but let's review at least the logic thing, please.
🌟

apps/web/src/pages/brand/tabs/LayoutEditor.tsx Outdated Show resolved Hide resolved
apps/web/src/pages/brand/tabs/LayoutEditor.tsx Outdated Show resolved Hide resolved
apps/web/src/pages/brand/tabs/LayoutEditor.tsx Outdated Show resolved Hide resolved
apps/web/src/pages/brand/tabs/LayoutEditor.tsx Outdated Show resolved Hide resolved
@ainouzgali ainouzgali merged commit f2e50b5 into NV-1409-Web---add-Layout-page Jan 12, 2023
@ainouzgali ainouzgali deleted the nv-1464-web-create-layout-page branch January 12, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants