New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLD-23] - Checkbox component #249
Conversation
This pull request is being automatically deployed with Vercel (learn more). docs – ./docs🔍 Inspect: https://vercel.com/relayed/docs/3iev9c8D3U8qpacr7iMBamRRT8J9 [Deployment for 747b949 canceled] storybook – ./🔍 Inspect: https://vercel.com/relayed/storybook/HsP2AzW6f2Jf4wYVJTs5KgBy4tLz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rockingrohit9639 thank you for contributing!!
Amazing work, I really loved your initiative :)
Just please check out the comments about the deign details.
Let me know if you need anything
Okay @ainouzgali I will do all the required changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks greattt!
just that change in background please
thank you :)))
Co-authored-by: ainouzgali <ainouzgali@gmail.com>
@ainouzgali I have done all the required changes. Please have a look and merge if possible. |
@rockingrohit9639 Great job on your first pr!! Thank you for contributing 🎉⭐️ |
Why?
We are in the process of creating our new core components using mantine and creating our very own storybook for easier UI development.
To learn more about our design system see #219
How?
To start contributing you need to run storybook locally:
To contribute, add a new component directory named
checkbox
inapps/web/src/design-system/
with the following files:1. Component file, overriding Mantine’s default implementation based on the design below.
2. Styles implementation, to fit our design. Consider dark and light color scheme.
3. Create a story for the checkbox component, showcasing our designs options (Checked, and un-checked).
Checkbox designs
Checkbox dark scheme:
Checkbox - Relayed Design System (Figma)
Checkbox light scheme:
Checkbox - Relayed Design System (Figma)
Need help?
For any questions feel free to contact us on discord 😃