Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLD-23] - Checkbox component #249

Merged
merged 7 commits into from Feb 13, 2022
Merged

[RLD-23] - Checkbox component #249

merged 7 commits into from Feb 13, 2022

Conversation

rockingrohit9639
Copy link
Contributor

@rockingrohit9639 rockingrohit9639 commented Feb 10, 2022

Why?

We are in the process of creating our new core components using mantine and creating our very own storybook for easier UI development.

To learn more about our design system see #219

How?

To start contributing you need to run storybook locally:

npm run setup:project
cd apps/web 
npm run storybook

To contribute, add a new component directory named checkbox in apps/web/src/design-system/ with the following files:

1. Component file, overriding Mantine’s default implementation based on the design below.

2. Styles implementation, to fit our design. Consider dark and light color scheme.

3. Create a story for the checkbox component, showcasing our designs options (Checked, and un-checked).

Checkbox designs

Checkbox dark scheme:

Checkbox - Relayed Design System (Figma)

Checkbox light scheme:

Checkbox - Relayed Design System (Figma)

See the Button component for an implementation example.

Need help?

For any questions feel free to contact us on discord 😃

@vercel
Copy link

vercel bot commented Feb 10, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

docs – ./docs

🔍 Inspect: https://vercel.com/relayed/docs/3iev9c8D3U8qpacr7iMBamRRT8J9
✅ Preview: Canceled

[Deployment for 747b949 canceled]

storybook – ./

🔍 Inspect: https://vercel.com/relayed/storybook/HsP2AzW6f2Jf4wYVJTs5KgBy4tLz
✅ Preview: https://storybook-git-fork-rockingrohit9639-master-relayed.vercel.app

Copy link
Contributor

@ainouzgali ainouzgali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rockingrohit9639 thank you for contributing!!
Amazing work, I really loved your initiative :)
Just please check out the comments about the deign details.
Let me know if you need anything

.gitpod.yml Outdated Show resolved Hide resolved
@rockingrohit9639
Copy link
Contributor Author

@rockingrohit9639 thank you for contributing!! Amazing work, I really loved your initiative :) Just please check out the comments about the deign details. Let me know if you need anything

Okay @ainouzgali I will do all the required changes.

@gitpod-io
Copy link

gitpod-io bot commented Feb 10, 2022

Copy link
Contributor

@ainouzgali ainouzgali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks greattt!
just that change in background please
thank you :)))

apps/web/src/design-system/checkbox/Checkbox.styles.ts Outdated Show resolved Hide resolved
Co-authored-by: ainouzgali <ainouzgali@gmail.com>
@rockingrohit9639
Copy link
Contributor Author

@ainouzgali I have done all the required changes. Please have a look and merge if possible.

@ainouzgali ainouzgali merged commit 62a4ef6 into novuhq:master Feb 13, 2022
@ainouzgali
Copy link
Contributor

@rockingrohit9639 Great job on your first pr!! Thank you for contributing 🎉⭐️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants